Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve cli from main shadcn-ui source, custom ui dir #324

Merged
merged 34 commits into from
Mar 6, 2024

Conversation

sadeghbarati
Copy link
Collaborator

close #308

Sry for the bad commit messages I really don't know how to write a good commit message 😶‍🌫️

@zernonia
Copy link
Member

zernonia commented Feb 6, 2024

Thanks for the PR and using those package from unjs @sadeghbarati ! It is so much easier to use!

One point to note tho.. I don't quite understand the idea of ui alias, do you have relevant PR from shadcn-ui?

@sadeghbarati

This comment was marked as resolved.

@sadeghbarati
Copy link
Collaborator Author

sadeghbarati commented Feb 13, 2024

@zernonia

With this 4762c67 change c12 will look for every supported extension that it has
but json5 has a bug that will be resolved after my PR gets merged to c12 repository


Only this 👉 utility is missing in our CLI (tw-prefix), which Idk how to solve cause I did not work with AST parsers like oxc-parser, ts-morph, or magic-string

Also, how to remove duplicated AST parsers and use one of them

https://github.com/shadcn-ui/ui/blob/main/packages/cli/src/utils/transformers/transform-tw-prefix.ts

and it's also supports .config directory
@zernonia
Copy link
Member

Thanks @sadeghbarati ! I can help look at tw-prefix 😁

@unovue unovue deleted a comment from changeset-bot bot Mar 4, 2024
@zernonia
Copy link
Member

zernonia commented Mar 5, 2024

@sadeghbarati added the tw prefix feature to CLI. Do have a look! If it's all good then we can merge! 😁

@zernonia
Copy link
Member

zernonia commented Mar 6, 2024

@sadeghbarati the prefix need more work.. I've temporary hide the config. I think we can merge this in and have another PR for the prefix

@sadeghbarati sadeghbarati merged commit 0e84af7 into unovue:dev Mar 6, 2024
2 checks passed
@sadeghbarati sadeghbarati deleted the cli-nypm-and-other-improves branch March 6, 2024 02:08
@msyfls123
Copy link

Want to know further information of recovering prefix option, actually I really need this option.
Plz 🙏🏻

@zernonia
Copy link
Member

@sadeghbarati can you create an issue for adding prefix? 😁 Maybe someone can help contribute to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate tailwind classes with cssVariables: false which override others
3 participants