Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add an option to component.json to resolve nuxt buildDir #447

Merged
merged 6 commits into from
May 6, 2024

Conversation

samk-dev
Copy link
Contributor

@samk-dev samk-dev commented Apr 1, 2024

Adds the option to set buildDir for nuxt if it's changed from nuxt.config.

It might be missing to be set from the prompt when running npx shadcn-vue@latest init if it's necessary please let me know so I can take a look at it asp.

closes #429

@zernonia
Copy link
Member

zernonia commented Apr 1, 2024

Thanks @samk-dev ! Adding buildDir would help for your case. However I think let's offer this flexibility to other framework too. Currently the tsconfig is expected to be placed in certain folder, I believe adding tsConfigPath config option would be a solution. 😁

@samk-dev
Copy link
Contributor Author

samk-dev commented Apr 1, 2024

Welcome :)

yes adding a tsConfigPath makes more sense to support Astro and Laravel as well. I will check the build settings for each framework and make an update the pr. thanks for the input 🙂

@samk-dev
Copy link
Contributor Author

samk-dev commented Apr 5, 2024

hey @zernonia I am back 🙂

I have checked the rest of the frameworks and saw that Astro is almost like Nuxt the buildDir it can be defined from astro.config, so maybe for simplicity we just add an option for tsConfigPath instead of

 nuxt: z.object({
      buildDir: z.string().default('.nuxt'),
    }).optional()

If it's okay with you let me know and will do the changes and update the pr 🙂

thanks

@zernonia
Copy link
Member

zernonia commented Apr 6, 2024

Thanks for looking into that @samk-dev . I agree, let's go with adding tsConfigPath as option 😁

@zernonia zernonia marked this pull request as draft April 6, 2024 02:59
@samk-dev
Copy link
Contributor Author

samk-dev commented Apr 6, 2024

@zernonia I have updated the pr with the needed changes 🙂

  • added tsConfigPath
  • updated tests
  • updated docs

@samk-dev samk-dev marked this pull request as ready for review April 15, 2024 07:45
@sadeghbarati sadeghbarati requested a review from zernonia May 6, 2024 06:49
@zernonia zernonia merged commit 10319df into unovue:dev May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants