Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Dashboards 05, 06 and 07 #452

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Create Dashboards 05, 06 and 07 #452

merged 6 commits into from
Apr 3, 2024

Conversation

lucasbois1
Copy link
Contributor

No description provided.

@sadeghbarati sadeghbarati mentioned this pull request Apr 1, 2024
Closed
@lucasbois1 lucasbois1 marked this pull request as draft April 1, 2024 19:52
@lucasbois1
chore: update index.ts
00278bb 
Add Dashboard05 to index.ts
@lucasbois1 lucasbois1 marked this pull request as ready for review April 1, 2024 20:01
@sadeghbarati
Copy link
Collaborator

Thanks for your time

Please note that you are not including Dashboard05.vue new-york style in this PR

Also, I would add other Dashboard examples in one PR

@lucasbois1
Copy link
Contributor Author

Thanks for your time

Please note that you are not including Dashboard05.vue new-york style in this PR

Also, I would add other Dashboard examples in one PR

Oh, I can add the new-york style too if you want

@lucasbois1 lucasbois1 marked this pull request as draft April 1, 2024 20:33
@lucasbois1
chore: create Dashboard05.vue new-york
7bceebf 
Create Dashboard05 new-york version
@lucasbois1 lucasbois1 marked this pull request as ready for review April 1, 2024 20:39
@sadeghbarati
Copy link
Collaborator

Please run pnpm run build:registry in apps/www directory again

@lucasbois1 lucasbois1 marked this pull request as draft April 1, 2024 20:54
@lucasbois1 lucasbois1 marked this pull request as ready for review April 1, 2024 20:59
@zernonia
Copy link
Member

zernonia commented Apr 2, 2024

Thanks for your time

Please note that you are not including Dashboard05.vue new-york style in this PR

Also, I would add other Dashboard examples in one PR

Hi @lucasbois1 ! Let's add Dashboard06 and Dashboard07 in this PR too ya 😁

@lucasbois1
Copy link
Contributor Author

Thanks for your time
Please note that you are not including Dashboard05.vue new-york style in this PR
Also, I would add other Dashboard examples in one PR

Hi @lucasbois1 ! Let's add Dashboard06 and Dashboard07 in this PR too ya 😁

Hey @zernonia 👋
Ok, I'll add those too here
Anything more to say about the icons?

@lucasbois1 lucasbois1 marked this pull request as draft April 2, 2024 01:01
@lucasbois1 lucasbois1 changed the title Create Dashboard05.vue Create Dashboards 05, 06 and 07 Apr 2, 2024
@lucasbois1 lucasbois1 marked this pull request as ready for review April 2, 2024 01:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: f91cfe9a
Status: ⚡️ Deployment in progress...
Preview URL: https://c0de6181.shadcn-vue.pages.dev
Branch Preview URL: https://c0de6181.shadcn-vue.pages.dev

zernonia
zernonia approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @lucasbois1 ! 🤩

@zernonia zernonia merged commit 81a7515 into unovue:dev Apr 3, 2024
1 check passed
sadeghbarati added a commit to sadeghbarati/shadcn-vue that referenced this pull request Apr 4, 2024
@sadeghbarati
feat: new calendar
9d5f2a2 
docs: fix combobox.md ref usage (unovue#420)

feat: Blocks (unovue#428)

* chore: build registry

* feat: block preview

* refactor: change to use iframe
feat: add more blocks

* chore: fix build

* feat: add all other blocks

* feat: add copy button

* chore: cleanup

fix: can't install `drawer` in js project

fix: pin input highlight border (unovue#432)

fix(hover-card): add emits from `radix-vue` (unovue#435)

docs: fix `AccountForm.vue` example select language empty state (unovue#442)

feat: update

feat: update

feat: update

chore: update Dashboard03.vue (unovue#446)

Fix mismatch header lines in Block - Dashboard03 component.

chore: fix wrong class at `Authentication03.vue` block example (unovue#449)

used grid gap-2 instead of space-y-2

chore: add missing Separator import to `Announcement.vue` badge (unovue#450)

feat(Blocks): create Dashboards 05, 06 and 07 (unovue#452)

* Create Dashboard05.vue

* chore: update index.ts

Add Dashboard05 to index.ts

* chore: create Dashboard05.vue new-york

Create Dashboard05 new-york version

* build: build registry

* chore: add Dashboard06 and Dashboard07

* fix: update `html-for` to `for`

chore: updates min-size

chore: update blocks metadata

chore: fix column not hidden

chore: fix column not hidden

fix: add type button to v-calendar navigations to prevent form submission (unovue#461)

chore: bump radix-vue

chore: fresh lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadeghbarati sadeghbarati sadeghbarati left review comments

@zernonia zernonia zernonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasbois1 @sadeghbarati @zernonia