Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt-module): auto inject lib/utils & refresh the playground #528

Merged
merged 19 commits into from
May 7, 2024
Merged

feat(nuxt-module): auto inject lib/utils & refresh the playground #528

merged 19 commits into from
May 7, 2024

Conversation

MuhammadM1998
Copy link
Contributor

@MuhammadM1998 MuhammadM1998 commented May 4, 2024

This PR is an initial step to improve the nuxt module for shadcn-vue. Huge thanks to https://github.com/ineshbose for helping me out!

Module Changes

  • Injected lib/utils by the module into buildDir. Now the CLI don't need to inject this file in Nuxt projects, making the file tree more cleaner. An alias for @/lib/utils is created to point the injected file for backward compatibility. Also a soft warning is displayed if a lib/utils file is found in the root and recommends to remove it as it's redundant.
  • Bumped deps (Notably @nuxt/module-builder which resolves an harmless but annoying warning)

Playground Changes

  • Fixed the issue of tailwindcss classes not applied because nuxtjs/tailwindcss was installed but not added to playground's modules
  • Generated missing tailwind.css by the CLI
  • Bumped Button component by the CLI
  • Refreshed the playground style as it was really dull to me and added a dark mode switch (with tailwindcss and radix-vue/icons which are already dependencies)
Before After

Next Steps

I'll create an issue for those to discuss them first

@sadeghbarati
Copy link
Collaborator

@MuhammadM1998 Hey thanks for PR

Please check shadcn-vue form components here

https://github.com/radix-vue/shadcn-vue/blob/dev/apps/www/src/lib/registry/default/ui/form/index.ts#L1

Related issue #172

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @MuhammadM1998 !! Love the implementation and the "Next Steps" plan for this!

@zernonia zernonia merged commit 631ffb8 into unovue:dev May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants