-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt-module): auto inject lib/utils
& refresh the playground
#528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MuhammadM1998 Hey thanks for PR Please check Related issue #172 |
sadeghbarati
reviewed
May 5, 2024
MuhammadM1998
commented
May 5, 2024
zernonia
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @MuhammadM1998 !! Love the implementation and the "Next Steps" plan for this!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial step to improve the nuxt module for
shadcn-vue
. Huge thanks to https://github.com/ineshbose for helping me out!Module Changes
lib/utils
by the module intobuildDir
. Now the CLI don't need to inject this file in Nuxt projects, making the file tree more cleaner. An alias for@/lib/utils
is created to point the injected file for backward compatibility. Also a soft warning is displayed if alib/utils
file is found in the root and recommends to remove it as it's redundant.@nuxt/module-builder
which resolves an harmless but annoying warning)Playground Changes
nuxtjs/tailwindcss
was installed but not added to playground'smodules
tailwind.css
by the CLIButton
component by the CLINext Steps
I'll create an issue for those to discuss them first
components.json
options to the module #271 by passing thecomponents.json
options to the module then reading them from the CLI when in a Nuxt projectnuxtjs/tailwindcss
modulenuxtjs/color-mode
module