-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add number-field component #571
Conversation
@romanslonov Thanks for the PR, next time please create new branch for your PRs Everything looks good to me in Number Field except this behaviour in Number Field input, @zernonia
Number.Field.-.shadcn_vue.-.Google.Chrome.2024-05-26.09-11-47.mp4 |
Thanks for the PR @romanslonov ! Also, I kinda regret adding |
Yes, what if you remove |
Yup that's what I should've done hahaha.. Since the |
I will submit a PR to radix-vue to remove it, and then update this PR as well |
Let's wait for new Number Field fixes to be released, then we can merge this |
fix new-york and default path for components
fix new-york example DatePickerWithIndependentMonths to use related icon @radix-icons/vue
Hello,
I have implemented this feature #567.
CleanShot.2024-05-25.at.14.09.20-converted.5.mp4
This is my first take. Let's discuss it.
upd:
I found a bug that seems to be when you completely erase the value of an input that is in the form, type a new value and if you press enter, the form will be submitted but the value is not updated, the value will only be updated on the blur event. You can find same behaviour on radix-vue preview page of this component.
<NumberFieldInput @keydown.enter.prevent />
this fix the issue though.