-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): highlight code block #831
Conversation
shadcn has code theme now @sadeghbarati Do I need to change it to the same theme as him? |
Ahh, yes You are right, please go with |
Hi @sadeghbarati I looked up the mdx themes used by shadcn, and I thought if we could add a code theme option to the header so that users could choose their favorite code theme Now it's |
Maybe it will be like this. What do you think? @sadeghbarati |
@zhangmo8 It's nice to have this, but I think one code |
Alright, I've changed the theme to github-xx-default. If needed, I can submit the code for the theme switching functionality later. |
Co-authored-by: Sadegh Barati <sadeghbaratiwork@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks π
@zhangmo8 Could you please check BlockContainer.vue seems to be using the previous shiki way |
It seems that I have missed something. Sorry for any inconvenience caused. I will submit another pull request to fix it. @sadeghbarati |
π Linked issue
close #829
β Type of change
π Description
highlight the demo code block
πΈ Screenshots (if appropriate)
before:
after:
π Checklist