Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar component mobile #840 #884

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

Whbbit1999
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #840

Sorting out the solution in #840.

Now you can add the sidebar part in tailwindcss.config.js, but I don’t know how to add the sidebar variable in the css fileπŸ˜“

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@carlospccarvalho
Copy link

carlospccarvalho commented Nov 14, 2024

I need this pr @zernonia

@zernonia
Copy link
Member

Thanks for the fix @Whbbit1999 !!! Can we update new-york style for these as well? 😁

@Whbbit1999
Copy link
Contributor Author

I think you can update.Now the sidebar css variables I haven't been able to integrate it into the cli.

@Whbbit1999
Copy link
Contributor Author

The current changes should only affect the Sidebar Component.

@zernonia zernonia merged commit 2d5ad5b into unovue:dev Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sidebar Mobile
3 participants