Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct silent type #47

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: correct silent type #47

merged 2 commits into from
Sep 19, 2024

Conversation

jspn-creative
Copy link
Contributor

@jspn-creative jspn-creative commented Sep 19, 2024

Description

The 'silent' configuration type and documentation was flipped — specifying silent:false as a config option has no effect as the default value actually is false. silent:true works as intended, but produces a type error.

Linked Issues

N/a

Additional context

N/a

Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Sep 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/unplugin/unplugin-turbo-console@47

commit: 1c7548e

@yuyinws
Copy link
Member

yuyinws commented Sep 19, 2024

Thanks for your contribution.

The silent type should be boolean instead of a fixed value.

If you want to avoid the plugin's terminal output, set silent to true:

import TurboConsole from 'unplugin-turbo-console/vite'

export default defineConfig({
    TurboConsole({
		silent: true
	})
})

@yuyinws yuyinws merged commit e327aad into unplugin:main Sep 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants