wireguard: Fix IPv6-only VPN #1353
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Wireguard VPNs have been introduced, it looks like nobody has ever tested them with an IPv6-only VPN.
As I already reported on the forums, when you create a Wireguard tunnel and select "IPv6 only" for the "Network Protocol", the tunnel doesn't start because the PostUp and PostDown commands are corrupted (see this).
PostUp and PostDown commands are being created for IPv4 routes, with an empty gateway IP, which obviously doesn't work.
With this change (not adding IPv4 routes if there's no IPv4 gateway or no IPv4 tunnel IP) at least lets me successfully start a Wireguard tunnel with IPv6.
I'm marking this as a draft PR (so please don't merge yet) because I haven't tested everything with this v6-only VPN and I'm not yet sure if this change doesn't break other use cases.