Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pathname strips out / #200

Closed
JSeligsohn opened this issue Feb 18, 2021 · 4 comments
Closed

Pathname strips out / #200

JSeligsohn opened this issue Feb 18, 2021 · 4 comments

Comments

@JSeligsohn
Copy link

Looks like in v1.5.0, pathname no longer includes the initial / from the url. Is that intentional? A breaking change from v1.4.7?

e.g.
url: /yippee/abc
1.4.7 -> path = /yippee/abc
1.5.0 -> path = yippee/abc
@JSeligsohn JSeligsohn mentioned this issue Feb 18, 2021
Closed
@3rd-Eden
Copy link
Member

It's a bug

@lpinca
Copy link
Member

lpinca commented Feb 18, 2021 •
edited
Loading

This is the same underlying issue as #199.

@JSeligsohn
Copy link
Author

Okay, good to know. I'll have to revert to 1.4.7 in the meantime.

@3rd-Eden 3rd-Eden mentioned this issue Feb 18, 2021
Merged
3rd-Eden added a commit that referenced this issue Feb 18, 2021
@3rd-Eden
[fix] Fixes relative path resolving #199 #200
9819b59
3rd-Eden added a commit that referenced this issue Feb 18, 2021
@3rd-Eden
[fix] Fixes relative path resolving #199 #200 (#201)
750d8e8 
* [fix] Fixes relative path resolving #199 #200
* [test] Additional extractProtocol tests
@3rd-Eden
Copy link
Member

Fixed in 1.5.1, thanks for reporting <3

This was referenced Mar 16, 2021
Merged
Closed
@sync-by-unito sync-by-unito bot mentioned this issue May 9, 2021
Closed
@danielgavrilov danielgavrilov mentioned this issue May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@3rd-Eden @lpinca @JSeligsohn