Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Add ability to provide arbitrary Xcode build settings #42

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Add ability to provide arbitrary Xcode build settings #42

merged 1 commit into from
Apr 23, 2021

Conversation

daltonclaybrook
Copy link
Contributor

Resolves #40

@bok- bok- self-assigned this Apr 22, 2021
@bok- bok- self-requested a review April 22, 2021 02:21
@bok- bok- added enhancement New feature or request minor A minor change according to semver labels Apr 22, 2021
bok-
bok- approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@bok- bok- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contribution. This looks like a great addition to me. I've tested it under macOS 11.2.3 with Xcode 12.4 and everything seems to be working as expected.

@bok- bok- merged commit 2d1a893 into unsignedapps:main Apr 23, 2021
@daltonclaybrook daltonclaybrook deleted the dalton/xc-settings branch April 23, 2021 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bok- bok- bok- approved these changes

Assignees

@bok- bok-

Labels
enhancement New feature or request minor A minor change according to semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for passing arbitrary build settings in addition to xcconfig
2 participants
@daltonclaybrook @bok-