Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to README #376

Merged
merged 6 commits into from
Mar 22, 2023
Merged

Update to README #376

merged 6 commits into from
Mar 22, 2023

Conversation

jayasimha-raghavan-unskript
Copy link
Member

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript commented Mar 22, 2023 •
edited by jira bot
Loading

Description

EN-4270

  • Updates to README_template.md
  • Updates to README_extending_docker.md
  • Updates to unskript-ctl to reference unskript-ctl instead of unskript-client

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published.

Documentation

Make sure that you have documented corresponding changes in this repository.

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript marked this pull request as draft March 22, 2023 17:33
dougsillars
dougsillars approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@dougsillars dougsillars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jayasimha-raghavan-unskript jayasimha-raghavan-unskript marked this pull request as ready for review March 22, 2023 21:08
@jayasimha-raghavan-unskript jayasimha-raghavan-unskript deleted the feature/EN-4270-jayasimha branch October 26, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsillars dougsillars dougsillars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayasimha-raghavan-unskript @dougsillars