Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only remove folder in sentencepiece check if it was created #1121

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Only remove folder in sentencepiece check if it was created #1121

merged 1 commit into from
Oct 11, 2024

Conversation

giuliabaldini
Copy link
Contributor

@giuliabaldini giuliabaldini commented Oct 9, 2024 •
edited
Loading

Hi there,

as promised, here is the PR!

Fixes #1119.
Reviewer: @danielhanchen.

Best,
Giulia

@giuliabaldini giuliabaldini changed the title Only remove folder in sentenpiece check if it was created Only remove folder in sentencepiece check if it was created Oct 9, 2024
@danielhanchen danielhanchen changed the base branch from main to nightly October 11, 2024 06:21
@danielhanchen
Copy link
Contributor

Thanks again!

@danielhanchen danielhanchen merged commit 13d434c into unslothai:nightly Oct 11, 2024
@giuliabaldini giuliabaldini deleted the fix-delete branch October 11, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model folder deleted after saving
2 participants
@giuliabaldini @danielhanchen