Fix ROPE extension issue and device mismatch #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am experiencing the same issue |
Yes, It works now. |
danielhanchen
added a commit
that referenced
this pull request
Jul 31, 2024
* bugs * Update _utils.py * flash-attn softcapping * Update gemma2.py * Update gemma2.py * Update gemma2.py * Update gemma2.py * Update mapper.py * Update README.md * Update _utils.py * Fix ROPE extension issue and device mismatch (#840) * When an exception has been assigned using as target, it is cleared at the end of the except clause.(https://docs.python.org/3/reference/compound_stmts.html#the-try-statement) * Update loader.py * round up to extend rope size * inv_freq.device changed, make sure they are on the same device --------- Co-authored-by: xiaoyang <xiaoyang@youzan.com> Co-authored-by: Daniel Han <danielhanchen@gmail.com> * Update gemma.py --------- Co-authored-by: XiaoYang <xyangk@gmail.com> Co-authored-by: xiaoyang <xiaoyang@youzan.com>
|
Thanks for this! I'll first merge this for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment:
Initial error:
I examined
self.inv_freqand found that although it was initialized on the CPU, it's now on the GPU, which caused this error:To resolve this, I modified
tto be on the same device asself.inv_freq, which solved the initial problem.However, a new error then occurred:
Upon checking the output, I discovered that my input sequence length is 34k, which exceeds the initial
current_rope_size. It appears thatextend_rope_embeddingwas not effective. The reason for this is thatround()was used for rounding, preventing the rope size from increasing. To address this, I changed it to use ceiling rounding instead.