-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Added: Toggle Audio #4
base: main
Are you sure you want to change the base?
Conversation
@@ -239,7 +165,104 @@ <h1 class="game-text">Game</h1> | |||
Score: <span id="score">10000</span> | |||
</div> | |||
</div> | |||
<div class="toggle-audio-container"> | |||
<div class="toggle-audio active"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Button is not visible
index.html
Outdated
// } | ||
// btn3.onclick = function () { | ||
// modal3.style.display = "flex"; | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
index.html
Outdated
} | ||
|
||
const toggleAudio = document.querySelector('.toggle-audio'); | ||
console.log(toggleAudio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
@KarthikS373 any updates? |
@grawish Made the necessary changes - removed commented codes, console logs and also fixed visibility of toggle button. please review |
@grawish Any updates on this? |
@KarthikS373 kindly resolve conflicts |
Resolved the conflicts |
@grawish Any updates over this?... |
Issue #2 Add a toggle for music
New Feature: Introduced a audio toggling button which can be used to toggle game audio
Screenshot:
Changes
Added a
playAudio
flag to control in game audio and toggled the flag using the control button