Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vessel Position returns Global Position relative to the Galactic Center Transform #117

Closed
Calaverah opened this issue Jan 21, 2024 · 3 comments
Labels
bug Something isn't working probably fixed Probably fixed, but should be confirmed stale Issue has not seen activity for 60 days

Comments

@Calaverah
Copy link

To recreate, compare the two vectors as follows:

CONSOLE.print_line("Vessel Global Position (Galactic Origin): " + vessel.global_position.to_local(galactic_origin()).to_string())
CONSOLE.print_line("Vessel Position (Main Body Celestial): " + vessel.position.to_string())

Currently I'm finding that the two vectors are identical when they should only match when you pass main_body.celestial_frame into the global position.

image

@untoldwind untoldwind added the bug Something isn't working label Jan 22, 2024
@untoldwind untoldwind added the probably fixed Probably fixed, but should be confirmed label Jan 22, 2024
@untoldwind
Copy link
Owner

untoldwind commented Jan 22, 2024

This should now work in 0.5.2.4

For some reason the internal body.coordinateSystem property is sometimes returns the reference frame of the parent body. Had to make this more explicit.
I wonder if that was introduced with the 0.2.x.x patch

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Issue has not seen activity for 60 days label Mar 23, 2024
Copy link

github-actions bot commented Apr 6, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working probably fixed Probably fixed, but should be confirmed stale Issue has not seen activity for 60 days
Projects
None yet
Development

No branches or pull requests

2 participants