Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for CONSOLE tweaking #129

Closed
PhilouDS opened this issue Feb 24, 2024 · 7 comments
Closed

Request for CONSOLE tweaking #129

PhilouDS opened this issue Feb 24, 2024 · 7 comments
Labels
enhancement New feature or request stale Issue has not seen activity for 60 days

Comments

@PhilouDS
Copy link
Contributor

Hi.
I wanted to know if it was possible to add method to open/close automatically the CONSOLE and to add a couple of R/W variables to change the height and the width of the CONSOLE.
Thanks :)

@untoldwind untoldwind added the enhancement New feature or request label Feb 24, 2024
@untoldwind
Copy link
Owner

I wanted to keep the CONSOLE independent of the window displaying it as there is still the possibility to display it in a different manner (e.g. in kOS there was a way to connect to it via telnet).

But I added a CONSOLE_WINDOW to ksp::ui to control it the same way I recently introduced for scripted UI-windows.

So in the next release there will be:

  • CONSOLE_WINDOW.open()
  • CONSOLE_WINDOW.close()
  • CONSOLE_WINDOW.center()
  • CONSOLE_WINDOW.is_closed
  • CONSOLE_WINDOW.size
  • CONSOLE_WINDOW.min_size
  • CONSOLE_WINDOW.position

@PhilouDS
Copy link
Contributor Author

Thank you very much!

@lefouvert
Copy link

My heart skip a beat at the idea of reintroducing telnet console :) (And I have to admit ingame console appearance control is a nice touch).

@untoldwind
Copy link
Owner

In 0.5.3.2 this should work:

use { Vessel } from ksp::vessel
use { CONSOLE_WINDOW } from ksp::ui

pub fn main_flight(vessel: Vessel) -> Result<Unit, string> = {
    CONSOLE.clear()

    CONSOLE_WINDOW.open()
    CONSOLE_WINDOW.center()
}

As for the telnet (or other type) console: I am still hesitant to put this into the main mod since doing networking might be frowned upon (if I remember correctly this kOS mod for KSP1 had an elaborate opt-in dialog for this).
But maybe this could be done with an optional addon that has KontrolSystem2 as a dependency.

@PhilouDS
Copy link
Contributor Author

I just tried inside the VAB, it's wonderful!
I never used telnet with kOS so I can't say.
Thanks again fr your work.

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Issue has not seen activity for 60 days label Apr 25, 2024
Copy link

github-actions bot commented May 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issue has not seen activity for 60 days
Projects
None yet
Development

No branches or pull requests

3 participants