Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the calendar on the calendar page #26

Closed
4 tasks done
leowrites opened this issue Nov 29, 2022 · 1 comment · Fixed by #33 or #41
Closed
4 tasks done

Implement the calendar on the calendar page #26

leowrites opened this issue Nov 29, 2022 · 1 comment · Fixed by #33 or #41
Assignees
Labels
CALENDAR This goes to the calendar page enhancement New feature or request priority: high

Comments

@leowrites
Copy link
Member

leowrites commented Nov 29, 2022

Implement the calendar with the following functionalities:

  • Vertically scrollable
  • Displays dates from current day to November 2021
  • Properly labels the day of the week
  • Click on a day will open up an empty page (to be implemented for logging daily symptoms)
@leowrites leowrites added the CALENDAR This goes to the calendar page label Nov 29, 2022
@leowrites leowrites added the enhancement New feature or request label Nov 29, 2022
@madelahn madelahn linked a pull request Nov 30, 2022 that will close this issue
@PierreLessard
Copy link
Contributor

For navigating to the logging daily symptom page, animated navigation is limited for the normal NavController. In the IOS app the daily symptom log page pops up from the bottom of the screen. Solutions online recommend using AnimatedNavHost. It seems to be simple to migrate. Here are some links with resources or discussions on it:

https://shortcut.io/tech/adding-animations-to-your-jetpack-compose-navigation/
https://google.github.io/accompanist/navigation-animation/

It uses the same Accompanist that I used to add swipeable navigation synced with tabs between the cycle and calendar page. It would be something to consider as during the meeting TPP did mention wanting more animations between pages.

Another current limitation seems to be with OverScrolling. Unfortunately there does not seem to be a simple way to animate OverScroll nicely, such as in the IOS app (excluding the glitch on the settings page). Thankfully this is just a minor aesthetics issue. Here is nice stackoverflow post on this issue:
https://stackoverflow.com/questions/70754397/how-to-implement-bounce-effect-on-jetpack-compose-lazy-column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment