#3 Created the Calendar Layout #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
2 tasks
|
Changed base branch so that it only shows @madelahn's changes |
madelahn
added a commit
that referenced
this pull request
Dec 5, 2022
madelahn
added a commit
that referenced
this pull request
Dec 5, 2022
leowrites
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Added Basic Calendar Cycle Top Bar
* added dependencies
* Styled Calendar Cycle Top Bar
* Changed TopBar to use tabs, added navigation
* setup basic navigation bar and graph
* added calender navgiation to FAB
* modularized BottomNav
* modularized FAB
* moved Screen enum to NavigationGraph
* Added Swiping to tabs, comments
* cleanup
* removed unused icon
* Updated Indicator Color
* removed unused colors
* added dependencies and tests
* Added activity to manifest - temp fix so tests run
Was seeing the following issues when I run tests in NavigationTest:
- android.content.ActivityNotFoundException: Unable to find explicit activity class {com.example.theperiodpurse.test/androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?
- android.content.ActivityNotFoundException: Unable to find explicit activity class {com.example.theperiodpurse.test/androidx.test.core.app.InstrumentationActivityInvoker$BootstrapActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?
Referred to android/android-test#196 for the fix.
Looks like this is fixed in androidx.test:core:1.5.0-alpha02.
* removed changes to manifest
* added androidTestResultsUserPreferences to gitignore
* added useful contentDescription to FAB
* added instrumental tests to CI
* added emulator use to workflow
* fixed typo in ci
* test with macOS
* specify system image
* Added content description for testing
* Added content description for testing
* Added testing for tabs
* added check to hide navigation bar during onboarding
* better implementation for hiding nav bar
* bandaid fix for tests
* fix tests
* create different screen to start in Calendar page
* added skipOnboarding option to AppScreen
* popback stack after onboarding
* #3 Created the Calendar Layout (#33)
* Added basic calendar setup to the screen
* Changed the minSDK in Project Configs
* Updated Visuals to look like original app
* Added Click Functionality
* Revert "#3 Created the Calendar Layout (#33)" (#38)
This reverts commit 18909c4.
Co-authored-by: Pierre-William Lessard <lessardpw@gmail.com>
Co-authored-by: Madeline <93456777+madelahn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed the basic calendar layout in
CalendarScreen.kt.The calendar is able to vertically scroll from the current month to 12 months before, with the labels for the day of the week and each month displayed as the header for each month.
Some notes and things to implement:
@OptIn(ExperimentalPagerApi::class)is added to every function, since the minimum SDK requirements for using the Calendar library requires a version above 21 (where the current min. SDK version is 21). I can set it to something higher but I just need confirm it won't conflict with anything else.