Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the calendar page layout #3

Closed
2 tasks done
leowrites opened this issue Nov 1, 2022 · 0 comments · Fixed by #25 or #33
Closed
2 tasks done

Create the calendar page layout #3

leowrites opened this issue Nov 1, 2022 · 0 comments · Fixed by #25 or #33
Assignees
@PierreLessard
Labels
CALENDAR This goes to the calendar page enhancement New feature or request

Comments

@leowrites
Copy link
Member

leowrites commented Nov 1, 2022 •
edited by PierreLessard
Loading

Create the basic layouts for the calendar page, please refer to the screenshots.
You don't need to have anything for the calendar view itself yet!

  • Tabs on the top with text "Calendar" and "Cycle"
  • Tabs on the bottom with respective icons and the red "+" button in the middle

Screen Shot 2022-11-01 at 1 50 07 PM
@leowrites leowrites added enhancement New feature or request CALENDAR This goes to the calendar page labels Nov 1, 2022
@PierreLessard PierreLessard self-assigned this Nov 20, 2022
@michaelng0107 michaelng0107 mentioned this issue Nov 28, 2022
Merged
@madelahn madelahn linked a pull request Nov 30, 2022 that will close this issue
#3 Created the Calendar Layout #33
Merged
madelahn added a commit that referenced this issue Dec 5, 2022
@madelahn
#3 Created the Calendar Layout (#33)
18909c4 
* Added basic calendar setup to the screen

* Changed the minSDK in Project Configs

* Updated Visuals to look like original app

* Added Click Functionality
madelahn added a commit that referenced this issue Dec 5, 2022
@madelahn
Revert "#3 Created the Calendar Layout (#33)"
6ca9c00 
This reverts commit 18909c4.
@madelahn madelahn mentioned this issue Dec 5, 2022
Closed
madelahn added a commit that referenced this issue Dec 5, 2022
@madelahn
Revert "#3 Created the Calendar Layout (#33)"
289a039 
This reverts commit 18909c4.
madelahn added a commit that referenced this issue Dec 5, 2022
@madelahn
Revert "#3 Created the Calendar Layout (#33)" (#38)
0ca3e86 
This reverts commit 18909c4.
leowrites pushed a commit that referenced this issue Dec 5, 2022
@michaelng0107 @PierreLessard @madelahn
Create calendar page layout and set up navigation (#25)
4a8f501 
* Added Basic Calendar Cycle Top Bar

* added dependencies

* Styled Calendar Cycle Top Bar

* Changed TopBar to use tabs, added navigation

* setup basic navigation bar and graph

* added calender navgiation to FAB

* modularized BottomNav

* modularized FAB

* moved Screen enum to NavigationGraph

* Added Swiping to tabs, comments

* cleanup

* removed unused icon

* Updated Indicator Color

* removed unused colors

* added dependencies and tests

* Added activity to manifest - temp fix so tests run

Was seeing the following issues when I run tests in NavigationTest:
- android.content.ActivityNotFoundException: Unable to find explicit activity class {com.example.theperiodpurse.test/androidx.test.core.app.InstrumentationActivityInvoker$EmptyActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?
- android.content.ActivityNotFoundException: Unable to find explicit activity class {com.example.theperiodpurse.test/androidx.test.core.app.InstrumentationActivityInvoker$BootstrapActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?

Referred to android/android-test#196 for the fix.
Looks like this is fixed in androidx.test:core:1.5.0-alpha02.

* removed changes to manifest

* added androidTestResultsUserPreferences to gitignore

* added useful contentDescription to FAB

* added instrumental tests to CI

* added emulator use to workflow

* fixed typo in ci

* test with macOS

* specify system image

* Added content description for testing

* Added content description for testing

* Added testing for tabs

* added check to hide navigation bar during onboarding

* better implementation for hiding nav bar

* bandaid fix for tests

* fix tests

* create different screen to start in Calendar page

* added skipOnboarding option to AppScreen

* popback stack after onboarding

* #3 Created the Calendar Layout (#33)

* Added basic calendar setup to the screen

* Changed the minSDK in Project Configs

* Updated Visuals to look like original app

* Added Click Functionality

* Revert "#3 Created the Calendar Layout (#33)" (#38)

This reverts commit 18909c4.

Co-authored-by: Pierre-William Lessard <lessardpw@gmail.com>
Co-authored-by: Madeline <93456777+madelahn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreLessard PierreLessard

Labels
CALENDAR This goes to the calendar page enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@PierreLessard @leowrites