Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Sorting for Website "Filter by Label" field dropdown. #3628

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

CxGainz
Copy link

@CxGainz CxGainz commented Nov 24, 2022

I'm very new to JS so I apologize in advance for my unconventional code. Something I noticed when browsing the website is that the dropdown that pops up when you click the "Filter by Label" field has two label options that start with colons before the label options that begin with the letter "A" appear. An example being the ": gift: BEGINNER" option which I believe the : gift: was supposed to show up as an emoji. The code I included makes it so that labels that begin with non-letters will be shoved to the bottom of the dropdown so the alphabetical "a/A" labels show up first. This was tested with Docker on Google Chrome on Windows 10. I wanted to point out what would happen if too many project owners inputted incorrect label options, it could clutter this list.

@soufainmohamd

This comment was marked as spam.

@soufainmohamd

This comment was marked as spam.

@shiftkey
Copy link
Member

@CxGainz apologies for the delay in getting to this - the changes seem fine, but it feels weird to be doing this processing each time this method runs, and I wonder if there's a different place we can do this sorting so it's done once. I'd also like to understand more about the "we render strange characters in the select inputs" case and what we might do to make this experience better, which may affect how this area works.

I need time to think about this, and sadly my time to do this sort of thing has been limited over the previous months...

@shiftbot
Copy link
Contributor

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under _data/projects/ so I don't have any feedback here.

As you make changes to this pull request, I'll re-run these checks.

@shiftkey
Copy link
Member

shiftkey commented Aug 10, 2024

npm run prettier-fix will fix this:

Checking formatting...
[warn] javascripts/projectsService.js
[warn] Code style issues found in the above file. Run Prettier with --write to fix.

@shiftkey shiftkey added needs work Reviewer has indicated changes need to be make to this pull request before it can be merged and removed needs review labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work Reviewer has indicated changes need to be make to this pull request before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants