Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page navigation #4925

Closed

Conversation

nobodys-ghost
Copy link
Contributor

@nobodys-ghost nobodys-ghost commented Nov 23, 2024

This pull request adds a navigation bar to index.html to allow users to jump between sections of the site without having to scroll past the lengthy projects section.

Closes #4923

@shiftbot
Copy link
Contributor

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under _data/projects/ so I don't have any feedback here.

As you make changes to this pull request, I'll re-run these checks.

@shiftkey
Copy link
Member

@nobodys-ghost the nav bar looks really big here, not sure of what it should look like but it doesn't feel great in my opinion:

Screenshot 2024-12-31 at 5 06 21 PM

I also added notes here about the utility of this navbar, which I think are relevant here #4976 (comment)

@shiftkey shiftkey added has-questions Reviewer has outstanding questions about the pull request and removed needs-review labels Dec 31, 2024
@nobodys-ghost nobodys-ghost deleted the page-navigation branch December 31, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-questions Reviewer has outstanding questions about the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar or Scrollbar
3 participants