Deprecate tools inheritance #224
Conversation
…ing possible return api call returns
| @@ -219,7 +219,7 @@ def _request( | |||
| data: Union[dict, list] = {}, | |||
| querystring: dict = {}, | |||
| return_text: bool = True, | |||
| ) -> Union[str, dict, requests.Response]: | |||
| ): # Union[str, dict, requests.Response]: | |||
There was a problem hiding this comment.
Not exactly sure why lots of ambiogus response type checks were only triggered after the class inheritance removal, but had to deactivate to not add type assertions in every function only so that mypy understands the return type. The current potential return types of our API are not ideal (besides json, a few responses give text or e.g. quicklook data chunks). This will at some point be adressed at API level.
There was a problem hiding this comment.
Was looking at the problem before and could not make sense of it. Don't think it's critical, but it would surely be good if that would be resolved some time in the future; as this repo is open source people will wonder. Maybe create a tech ticket?
chrieke
requested review from
rodrigoalmeida94,
nekhtiari,
markusuwe,
marooned20,
Onyothi and
thaisbendixen
| @@ -219,7 +219,7 @@ def _request( | |||
| data: Union[dict, list] = {}, | |||
| querystring: dict = {}, | |||
| return_text: bool = True, | |||
| ) -> Union[str, dict, requests.Response]: | |||
| ): # Union[str, dict, requests.Response]: | |||
There was a problem hiding this comment.
Was looking at the problem before and could not make sense of it. Don't think it's critical, but it would surely be good if that would be resolved some time in the future; as this repo is open source people will wonder. Maybe create a tech ticket?
Fully deprecates the Tools module inheritance in the other classes (after deprecation process). The tools functions will only be available from the
up42import object.Items:
For release: