Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CatalogBase class #678

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Improve CatalogBase class #678

merged 2 commits into from
Oct 8, 2024

Conversation

javidq
Copy link
Contributor

@javidq javidq commented Oct 8, 2024 •
edited
Loading

See changelog.

Checklist:

  • Test coverage
  • Version bump
  • Changelog update

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@javidq javidq marked this pull request as ready for review October 8, 2024 12:13
@javidq javidq requested review from up42-eva and a team as code owners October 8, 2024 12:13
andher1802
andher1802 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@andher1802 andher1802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javidq javidq merged commit aa44e8a into master Oct 8, 2024
5 checks passed
@javidq javidq deleted the improve-catalog-base branch October 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andher1802 andher1802 andher1802 approved these changes

@up42-eva up42-eva Awaiting requested review from up42-eva up42-eva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javidq @andher1802