Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix illust_comments method #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Danipulok
Copy link
Contributor

Fixes #378

# Conflicts:
#	pixivpy3/aapi.py
@upbit upbit added the wontfix label Jan 14, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it? Wont' it cause problems if altered to ajax api instead of app-api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course I have tested it. There's already a similar method that uses ajax API. That's why I proposed this way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to do this via app API. If there's a working one, please propose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

illust_comments returns <Response [404]>, even though illust_detail is okay
3 participants