This repository has been archived by the owner on May 30, 2024. It is now read-only.
make go covermod configurable #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
|
ping @negz @hasheddan @jbw976 , please kindly review, thanks! |
jbw976
reviewed
Nov 9, 2020
There was a problem hiding this comment.
Thanks for this contribution @wonderflow! Can you please update the PR description with some details about how this has been tested? Thank you!
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
wonderflow
force-pushed
the
covermode
branch
from
ac6ead0
to
d136216
Compare
|
@jbw976 Thanks , I've tested it. |
jbw976
reviewed
Nov 10, 2020
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
|
@jbw976 All fixed and again tested in https://github.com/wonderflow/test-build, Thanks! |
jbw976
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
looks good @wonderflow! thank you for incorporating the feedback and for driving this improvement! 💪
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 天元 jianbo.sjb@alibaba-inc.com
go test -raceneed CGO_ENABLED=1.Tested with my personal repo: https://github.com/wonderflow/test-build