This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Update download URL of uptest #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
requested review from
turkenh,
phisco,
ezgidemirel and
lsviben
as code owners
ulucinar
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Btw, after this PR is merged, build pipelines depending on an uptest version which is not present at the new location will break. Either we make this clear so that users of uptest update the version at least to v0.12.0 when they bump their repo's build submodules version, or if we want to be super kind to them, we could also push the previous releases of uptest to the new location so that upgrades are smoother. I currently assume this repo is mostly used in the Upbound organization but it's also a public repo (which might be a motivation for some extra care, for instance the crossplane/upjet-provider-template has a dependecy).
ulucinar
reviewed
Apr 19, 2024
6 tasks
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Change the download URL of uptest.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Tested locally