Remove goimports

[negz]

We invoke goimports in two places:

1. Automatically on generated files.
2. When running make imports

1 is bad practice; we should not edit generated code, even using tools. 2 is redundant; make lint invokes goimports via golangci-lint.

[negz]

Some context on this PR: I just lost an hour due to a bug in goimports. Running make generate in stack-azure was deleting corev1 imports from generated deepycopy files, despite them being needed by those files. Turns out make generate invokes goimports on generated files, does not use a pinned version of goimports, and the version of goimports I had cached had a bug in it.

[hasheddan]

LGTM

[jbw976]

I originally added this in e0558c9 during the migration to kubebuilder v2 because the generated files were failing linting checks (they weren't goimports valid), which was failing the builds. Do we no longer have this problem and the builds will still succeed after this invocation of goimports is removed?

[negz]

@jbw976 Was it golangci-lint that was balking, or some other system? golangci-lint should automatically ignore generated files.

[jbw976]

@negz I am not actually sure which specific tool it was (or if it was even linting at all), but a simple make was failing without the goimports call to clean up the generated files. Did you already try running make with this change to the build submodule and it completed OK?

[negz]

@jbw976 I tested it with stack-aws, but I just now tried stack-gcp and can reproduce the issue you were seeing. I've confirmed that if I add the following to .golangci-lint.yml there are no issues:

run:
  skip-files:
  - "zz_generated\\..+\\.go$"

My suggestion would be to add the above to the linter config in each repo - I don't think there's much value in linting generated code. I'll open PRs for that now.

[jbw976]

That sounds very reasonable, thank you for checking on that @negz! so we can go ahead and merge this then, and then pick up the new build submodule hash along with updating the .golangci-lint.yml config. Thank you! 💪

[negz]

Cross-linking some prior art here:

• Avoid generated files golang/lint#239 - go lint ignores generated files.
• https://github.com/golangci/golangci-lint/blob/4f3e4105/.golangci.example.yml#L34 - golangci-lint appears to intend to ignore generated files (but obviously does not in some cases).