Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addon instantiation ordering and clean deletion #11

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Dec 20, 2023

Description of your changes

  • Import eks security group for full control over it
  • Enable vpc-cni addon for explicit configuration with preserve: false
  • Create addons after nodegroup creation. Before this change, the csi addon stuck in the degraded state for more than 20 minutes
  • Now, with a proper ordering, the addons are ready almost immediately after instantiation
NAME                                                   READY   SYNCED   EXTERNAL-NAME                                    AGE
addon.eks.aws.upbound.io/configuration-aws-eks-dkwcw   True    True     configuration-aws-eks-4n8fl:aws-ebs-csi-driver   112s
addon.eks.aws.upbound.io/configuration-aws-eks-sq5z6   True    True     configuration-aws-eks-4n8fl:vpc-cni              112s


context on leaked ENIs deletion

terraform-aws-modules/terraform-aws-eks#2743 (comment)
aws/amazon-vpc-cni-k8s#1223 (comment)
aws/amazon-vpc-cni-k8s#69
aws/amazon-vpc-cni-k8s#2360

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

=== CONT  kuttl
    harness.go:402: run tests finished
    harness.go:511: cleaning up
    harness.go:553: skipping cluster tear down
    harness.go:554: to connect to the cluster, run: export KUBECONFIG="/Users/xnull/upbound/configuration-aws-eks/kubeconfig"
--- PASS: kuttl (2066.23s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (2065.73s)
PASS
12:00:06 [ OK ] running automated tests

@ytsarev ytsarev requested a review from haarchri December 20, 2023 11:14
* Import eks security group for full control over it
* Enable vpc-cni addon for explicit configuration with preserve: false
* Create addons after nodegroup creation. Before this change, the csi addon stuck in the degraded state for more than 20 minutes

Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev force-pushed the addons-and-clean-deletion branch from 4c3da41 to 064c64a Compare December 20, 2023 11:18
@ytsarev
Copy link
Member Author

ytsarev commented Dec 20, 2023

/test-examples

@ytsarev ytsarev merged commit 7102b62 into upbound:main Dec 20, 2023
1 check passed
@ytsarev ytsarev deleted the addons-and-clean-deletion branch December 20, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants