Use build submodule and adapt CI pipeline #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Signed-off-by: Hasan Turken <turkenh@gmail.com>
ytsarev
reviewed
Oct 3, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
jbw976
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
LGTM @turkenh, thanks for adding this! from your PR notes, it looks like the CI integration will be tested after merge. Anything else you think we can do to verify before merging? If not, I think you have permissions to merge yourself now :)
|
We will need to add the following repo secrets before merge: XPKG_ACCESS_ID and XPKG_TOKEN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR uses upbound/build submodule to build and publish configuration package (specifically upbound/build#203 and upbound/build#207).
It also adapts CI pipeline accordingly.
I have:
How has this code been tested
Ensure package is build under
_output/xpkgCI needs to be tested after merge.