Add EBS CSI driver for EKS #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This uses a solution discussed in crossplane-contrib/provider-upjet-aws#149 (comment) |
|
/test-examples |
|
/test-examples="examples/cluster-claim.yaml" |
Closed
|
/test-examples="examples/cluster-claim.yaml" |
|
/test-examples |
1 similar comment
|
/test-examples |
|
@rozcietrzewiacz Thanks a lot for this contribution! Could you please rebase with |
Without the EBS CSI driver, the default `StorageClass` is no longer sufficient on recent EKS - persistent volumes cannot be provisioned. This change adds the EBS "Addon" for EKS and attaches the default AWS Policy for EBS CSI Driver to the cluster nodegroup. Note: this just one of the ways it can be done, but others are not as straightforward to implement currently. Ref: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/install.md
|
close and reopen for test run |
haarchri
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
thanks for contribution - i rebased your branch @rozcietrzewiacz and tested locally LGTM
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
|
/test-examples |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the EBS CSI driver, the default
StorageClassis no longer sufficient on recent EKS - persistent volumes cannot be provisioned.Description of your changes
This change adds the EBS "Addon" for EKS and attaches the default AWS Policy for EBS CSI Driver to the cluster's nodegroup. Note: this just one of the ways it can be done, but others are not as straightforward to implement currently. A safer way would be to use IRSA, but that has not yet been implemented (see #85)
Ref: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/install.md
Fixes #96
How has this code been tested
xeks.aws.platformref.upbound.iocomposition