Defaulting to the GCP project specified in the ProviderConfig unless the optional spec.forProvider.project is given

[ulucinar]

What happened?

How can we reproduce it?

We hit a bug, whose root cause was that we just ignore the spec.forProvider.provider optional field's value when generating the Terraform ID for a managed resource. For resources with an optional spec.forProvider.project field, the expected behavior is to use the project name if one is specified with the MR, and if not, use the ProviderConfig's project.

There are other managed resources with an optional spec.forProvider.project field. Those configured with the config.IdentifierFromProvider external-name configuration should be fine but we need to make sure others implement the defaulting logic correctly. An example could be this one and we need to check this and the others.

What environment did it happen in?

• Provider Version: v0.29.0