Fix the external-name configuration for the ProjectSink.logging resource #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
stevendborrelli
approved these changes
Aug 8, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We have an external-name configuration error for the
ProjectSink.loggingresource as reported here. This PR fixes the issue for this specific resource and we will need to scan the configurations of other resources and also fix them.Fixes: #351
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've validated the fix by using the service account credentials and @stevendborrelli has verified it in Upbound Cloud via the federated credentials.
The provider packages used for validation are:
index.docker.io/ulucinar/provider-gcp-{logging,pubsub}:v0.36.0-rc.0.1.g1523f4b6andindex.docker.io/ulucinar/provider-family-gcp:v0.36.0-rc.0.1.g1523f4b6.