Add support for nested objects in output #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested changes
Mar 3, 2023
bobh66
reviewed
Mar 12, 2023
bobh66
requested changes
Mar 12, 2023
|
|
|
That was an accidental close. @bdwyertech Could you please rebase the PR? |
|
any news on this? I'd like to use list outputs from the provider in a composition without hacks and I guess this is the stuff I'm waiting for... |
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
ytsarev
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks a lot for the contribution, @bdwyertech !
Tested it e2e, it looks just great 👍
status:
atProvider:
outputs:
subnet_data:
arn: arn:aws:ec2:eu-west-1:12345:subnet/subnet-0481765836942e835
id: subnet-0481765836942e835
vpc_id: vpc-05d50d36843b95bc3
I've extended this PR with the associated example, linter, and pipeline dependency fixes.
@bobh66 as I added my own commits to this PR, can you please take a look before the final merge?
bobh66
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for nested object output.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested