Mirror Upbound/Crossplane to Spaces artifacts registry #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
approved these changes
Sep 16, 2024
jeanduplessis
approved these changes
Sep 16, 2024
.github/workflows/ci.yml
Outdated
| uses: imjasonh/setup-crane@v0.4 | ||
|
|
||
| - name: Copy Upbound Crossplane image to Spaces Artifacts Registry | ||
| run: crane cp xpkg.upbound.io/upbound/crossplane:${{ CROSSPLANE_VERSION }} xpkg.upbound.io/spaces-artifacts/crossplane:${{ CROSSPLANE_VERSION }} |
There was a problem hiding this comment.
The CROSSPLANE_VERSION variable doesn't exist in the workflow.
There was a problem hiding this comment.
It should be set by the Set Crossplane Version step before.
The problem seems to be ${{ CROSSPLANE_VERSION }} vs `${CROSSPLANE_VERSION}, which should be fixed now.
turkenh
force-pushed
the
push-to-spaces-artifacts
branch
2 times, most recently
from
35817d3
to
b873c9d
Compare
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
force-pushed
the
push-to-spaces-artifacts
branch
from
b873c9d
to
bd56982
Compare
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Mirrors Upbound/Crossplane images to Spaces Artifacts Registry from main and release branches.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
CI