Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to set the brokers via a command #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harmathy
Copy link
Contributor

This allows for using a script to determine the brokers list, e. g. in a CI environment.

@plicease
Copy link
Member

Is there a reason to use this over say --brokers=$(command)?

@harmathy
Copy link
Contributor Author

Yes, it makes setting brokers dynamically in CI environments much easier.

@plicease
Copy link
Member

Yes, it makes setting brokers dynamically in CI environments much easier.

Right, but my question is can't you do the same thing with bash command interpolation --brokers=$(command -args foo bar whatever)

@harmathy
Copy link
Contributor Author

This only works in environments, which run inside a shell. I can imagine a lot of use cases, where this could be useful: If you run this within a systemd unit, there is no shell for shell expansion. Or if it called by a Python program or if you call it in your IDE. If you want your container images to be small, there might be no shell at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants