backend/postgres: Various improvments #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisMontagne
requested review from
Sypheos and
BillotP
and removed request for
a team
Sypheos
reviewed
Oct 18, 2023
| @@ -5,13 +5,13 @@ go 1.18 | |||
| require ( | |||
| github.com/lib/pq v1.4.0 | |||
| github.com/mattn/go-sqlite3 v1.13.1-0.20200416054559-98a44bcf5949 | |||
| github.com/stretchr/testify v1.6.1 | |||
| github.com/stretchr/testify v1.8.4 | |||
There was a problem hiding this comment.
also bump the go version ? (and in the workflow file)
| } | ||
|
|
||
| func (qce *queryCanceledError) Is(target error) bool { | ||
| return target == context.Canceled |
There was a problem hiding this comment.
Should we fall back to a the wrapped error if the condition failed ?
Suggested change
| return target == context.Canceled | |
| if target == context.Canceled { | |
| return true | |
| } | |
| return errors.Is(qce.cause, target) |
?
There was a problem hiding this comment.
it is done directly by the std lib in the implementation of errors.Is
There was a problem hiding this comment.
Won't we need the Unwrap method to be implemented on this type then ?
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
upfluence-bot
added
reviewed/needs-review
reviewed/needs-work
and removed
reviewed/needs-work
reviewed/needs-review
labels
Sypheos
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR packs 3 improvemnt:
lib/pq brings a new sslsni option turns on by default: lib/pq#1088. It breaks our setup with RDS CA.
if a context is canceled mid request now errors.Is(err, context.Canceled) should return tru
For CA key rotation it will be critical
What are the observable changes?
Good PR checklist
Additional Notes