Default values are not overridden when constructing a model

[nandi95]

Is there an existing issue for this?

• I have searched the existing issues

Search terms

field
property
attribute
default value
constructing
new model
magic access
descriptors
accessor
mutator
constructing

Current Behavior

If a model has default values like so:

export default class User extends Model {
  public myAttribute: number = 1;
}

when constructing a class with myAttribute value passed in as 2 new User({ myAttribute: 2 }) key will still be 1.
Furthermore, casting and mutators will not work either.

Expected Behavior

Even if there are default values, the attribute should still be set to the passed value when constructing the class.

Environment

- OS: darwin
- Node: 17.4.0
- npm: 8.3.1

Anything else?

This is due to js first constructing the parent class and properties defined in the subclass will only be actually set when it comes to constructing the subclass. By this time the property descriptors have already been set up and now being overwritten.

Workaround

Avoid constructing classes by using the create method or construct the class and call the fill with the intended attributes on the instance

Reproduction

No response

[nandi95]

This is related to #180 as the issue stems from setting default values.