[feature] cwd option #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etagwerker
reviewed
Jan 28, 2023
There was a problem hiding this comment.
@KostiantynPopovych This looks very interesting. Just had one question in the tests you added.
tests/engine/cwd-option.spec.ts
Outdated
| describe('cwd option', () => { | ||
| it('possible to perform the check in the existing directory passing a relative path', async () => { | ||
| const checkResult = await depngn({ version: '18.0.0', cwd: '.' }); | ||
| expect(checkResult).not.toBeNull(); |
There was a problem hiding this comment.
@KostiantynPopovych Can we actually expect something a bit more specific? This is the same expectation as specified in the next test case.
There was a problem hiding this comment.
@etagwerker, thank you for reviewing! And it is a great point. I'll take a look at what we can expect here)
There was a problem hiding this comment.
@KostiantynPopovych sounds good. Did you get a chance to improve this part?
There was a problem hiding this comment.
@etagwerker just pushed my update, thank you.
etagwerker
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding an ability to specify the path where the check should be performed.