Ignore missing topic errors on the health check #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Americas
force-pushed
the
support/ignore-topic-not-found-errors
branch
from
bc3c47a to
cfee0f4
Compare
satazor
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reader is setup with a topic that does not yet exist, the lookup will fail with a TOPIC_NOT_FOUND status.
Since this is an error, the health check is becoming degraded because of it, but it really shouldn't, the call to the nsqlookup worked, it is just that the error is misleading.
With this PR, this specific error will be ignored for health check purposes, although it will still be emitted through the
error lookupevent.