Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let bunyan EPIPE errors silently fail #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benoitkoenig
Copy link

@benoitkoenig benoitkoenig commented Jun 3, 2022

Related to https://uphold.atlassian.net/browse/BKO-2611

This PR intends to fix the issue raised on bunyan here: trentm/node-bunyan#491.

@benoitkoenig benoitkoenig force-pushed the bugfix/handle-epipe-errors branch from 25030e0 to b13117e Compare June 3, 2022 11:25
@fixe
Copy link
Member

fixe commented Jun 24, 2022

2>&1

@benoitkoenig
Copy link
Author

@fixe I have tested your suggestion, but I can see 2 flaws with it:

  • 2>&1 needs to be documented, and the other developers I asked told me that they did not know this solves the issue. This is also something we need to explain to new devs and remember to do systematically, adding unnecessary overhead.
  • The process do not shut down systematically, and I still need to do a ps to check if I need to kill my node processes.
    @rbrtribeiro told me that there had been a discussion about this, but I don't know what was said so please feel free to share with me any concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants