Add sentry usage example #19

kurayama · 2017-03-23T12:12:32Z

No description provided.

ruimarinho · 2017-03-23T14:30:50Z

README.md

@@ -51,7 +51,7 @@ processManager.once(async () => {

 And it will now manage your node process.

-### Loop
+### loop()


loop(fn), on(fn), etc?

ruimarinho · 2017-03-23T14:31:02Z

README.md

+### [sentry.io](https://sentry.io)
+
+The recommended way to report errors to sentry is by adding a `exit` hook and
+sending each error using `captureException`.


Remove newline?

ruimarinho · 2017-03-23T14:31:50Z

README.md

+### [sentry.io](https://sentry.io)
+
+The recommended way to report errors to sentry is by adding a `exit` hook and
+sending each error using `captureException`.


Mention "(or captureExceptionAsync in case you promisify the method using a library like bluebird)"?

We need to return a promise, simply using captureException might not report the error as exit might run before the callback resolves.
I will revisit the wording.

ruimarinho · 2017-03-23T14:31:57Z

README.md

+const Promise = require('bluebird');
+const raven = Promise.promisifyAll(require('raven'));
+
+raven.config('https://******@sentry.io/<app id>').install();


ruimarinho · 2017-03-23T14:32:25Z

README.md

+
+processManager.addHook({
+  handler(errors) {
+    return Promise.map(errors, error => raven.captureExceptionAsync(error));


Did you end up revisiting - and confirming or rejecting - the map issue that fails all requests in case the first one fails?

If a promise fails during the mapping, the mapping stops and the overall promise rejected.
In this case, if there is a problem reporting a error to sentry (due to network, etc), probably the next ones will fail too (as they are running almost at the same time).

Americas · 2017-03-23T16:10:22Z

README.md

+
+### [sentry.io](https://sentry.io)
+
+The recommended way to report errors to sentry is by adding a `exit` hook and sending each error using a promisified `captureException`.


an exit hook

ruimarinho · 2017-03-23T16:14:47Z

README.md

@@ -110,7 +110,7 @@ processManager.once(function *() {
 });
 ```

-### Shutdown
+### shutdown(fn)


{ error, force = false } = {}

ruimarinho · 2017-03-23T16:18:25Z

README.md

@@ -92,7 +92,7 @@ function handler*(value) {
 client.on('event', processManager.on(handler));
 ```

-### Once
+### once(fn)


Rename func to fn?

ruimarinho · 2017-03-23T16:38:09Z

README.md

-   `args.handler` _(function)_: a function that returns a value or a thenable.
-   `args.type` _(string)_: the hook type.
-   `[args.name='a handler']` _(string)_: identifies the hook.
+- `args.handler` _(function)_: a function that returns a value or a thenable.


kurayama self-assigned this Mar 23, 2017

kurayama requested a review from ruimarinho March 23, 2017 12:12

ruimarinho requested changes Mar 23, 2017

View reviewed changes

kurayama force-pushed the support/improve-documentation branch 2 times, most recently from 8ab85a1 to b7213bd Compare March 23, 2017 15:32

Americas reviewed Mar 23, 2017

View reviewed changes

ruimarinho reviewed Mar 23, 2017

View reviewed changes

kurayama force-pushed the support/improve-documentation branch 5 times, most recently from 3c967b5 to dab9d0d Compare March 23, 2017 16:32

ruimarinho reviewed Mar 23, 2017

View reviewed changes

Add sentry usage example

75ff933

kurayama force-pushed the support/improve-documentation branch from dab9d0d to 75ff933 Compare March 23, 2017 16:44

ruimarinho approved these changes Mar 23, 2017

View reviewed changes

ruimarinho merged commit 240b16f into master Mar 23, 2017

ruimarinho deleted the support/improve-documentation branch March 23, 2017 17:03

kurayama mentioned this pull request Mar 23, 2017

Stacktraces getting lost #8

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sentry usage example #19

Add sentry usage example #19

kurayama commented Mar 23, 2017

ruimarinho Mar 23, 2017

ruimarinho Mar 23, 2017

ruimarinho Mar 23, 2017

kurayama Mar 23, 2017

ruimarinho Mar 23, 2017

ruimarinho Mar 23, 2017

kurayama Mar 23, 2017

Americas Mar 23, 2017

ruimarinho Mar 23, 2017

ruimarinho Mar 23, 2017

ruimarinho Mar 23, 2017


		### [sentry.io](https://sentry.io)

		The recommended way to report errors to sentry is by adding a `exit` hook and sending each error using a promisified `captureException`.

Add sentry usage example #19

Add sentry usage example #19

Conversation

kurayama commented Mar 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment