Only change BigNumber.DEBUG during validation

uphold · Jan 10, 2024 · 3d37495 · 3d37495
1 parent b37a5d9
commit 3d37495
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 12 deletions.
diff --git a/src/asserts/big-number-assert.js b/src/asserts/big-number-assert.js
@@ -26,8 +26,6 @@ module.exports = function bigNumberAssert({ validateSignificantDigits = true } =
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Class name.
  */
@@ -39,7 +37,11 @@ module.exports = function bigNumberAssert({ validateSignificantDigits = true } =
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  const number = new BigNumber(value);
 
  if (Number.isNaN(number.toNumber())) {
@@ -51,6 +53,8 @@ module.exports = function bigNumberAssert({ validateSignificantDigits = true } =
  }
 
  throw new Violation(this, value);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;

diff --git a/src/asserts/big-number-equal-to-assert.js b/src/asserts/big-number-equal-to-assert.js
@@ -28,8 +28,6 @@ module.exports = function bigNumberEqualToAssert(value, { validateSignificantDig
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Extend `Assert` with `BigNumberAssert`.
  */
@@ -55,7 +53,11 @@ module.exports = function bigNumberEqualToAssert(value, { validateSignificantDig
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  Assert.bigNumber({ validateSignificantDigits }).validate(value);
 
  const number = new BigNumber(value);
@@ -72,6 +74,8 @@ module.exports = function bigNumberEqualToAssert(value, { validateSignificantDig
  }
 
  throw new Violation(this, value, context);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;

diff --git a/src/asserts/big-number-greater-than-assert.js b/src/asserts/big-number-greater-than-assert.js
@@ -28,8 +28,6 @@ module.exports = function bigNumberGreaterThanAssert(threshold, { validateSignif
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Extend `Assert` with `BigNumberAssert`.
  */
@@ -55,7 +53,11 @@ module.exports = function bigNumberGreaterThanAssert(threshold, { validateSignif
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  Assert.bigNumber({ validateSignificantDigits }).validate(value);
 
  const number = new BigNumber(value);
@@ -72,6 +74,8 @@ module.exports = function bigNumberGreaterThanAssert(threshold, { validateSignif
  }
 
  throw new Violation(this, value, context);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;

diff --git a/src/asserts/big-number-greater-than-or-equal-to-assert.js b/src/asserts/big-number-greater-than-or-equal-to-assert.js
@@ -28,8 +28,6 @@ module.exports = function bigNumberGreaterThanOrEqualToAssert(threshold, { valid
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Extend `Assert` with `BigNumberAssert`.
  */
@@ -54,7 +52,11 @@ module.exports = function bigNumberGreaterThanOrEqualToAssert(threshold, { valid
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  Assert.bigNumber({ validateSignificantDigits }).validate(value);
 
  const number = new BigNumber(value);
@@ -71,6 +73,8 @@ module.exports = function bigNumberGreaterThanOrEqualToAssert(threshold, { valid
  }
 
  throw new Violation(this, value, context);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;

diff --git a/src/asserts/big-number-less-than-assert.js b/src/asserts/big-number-less-than-assert.js
@@ -28,8 +28,6 @@ module.exports = function bigNumberLessThan(threshold, { validateSignificantDigi
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Extend `Assert` with `BigNumberAssert`.
  */
@@ -55,7 +53,11 @@ module.exports = function bigNumberLessThan(threshold, { validateSignificantDigi
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  Assert.bigNumber({ validateSignificantDigits }).validate(value);
 
  const number = new BigNumber(value);
@@ -72,6 +74,8 @@ module.exports = function bigNumberLessThan(threshold, { validateSignificantDigi
  }
 
  throw new Violation(this, value, context);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;

diff --git a/src/asserts/big-number-less-than-or-equal-to-assert.js b/src/asserts/big-number-less-than-or-equal-to-assert.js
@@ -28,8 +28,6 @@ module.exports = function bigNumberLessThanOrEqualToAssert(threshold, { validate
  throw new Error('BigNumber is not installed');
  }
 
- BigNumber.DEBUG = !!validateSignificantDigits;
-
  /**
  * Extend `Assert` with `BigNumberAssert`.
  */
@@ -55,7 +53,11 @@ module.exports = function bigNumberLessThanOrEqualToAssert(threshold, { validate
  */
 
  this.validate = value => {
+ const bigNumberDebug = BigNumber.DEBUG;
+
  try {
+ BigNumber.DEBUG = !!validateSignificantDigits;
+
  Assert.bigNumber({ validateSignificantDigits }).validate(value);
 
  const number = new BigNumber(value);
@@ -72,6 +74,8 @@ module.exports = function bigNumberLessThanOrEqualToAssert(threshold, { validate
  }
 
  throw new Violation(this, value, context);
+ } finally {
+ BigNumber.DEBUG = bigNumberDebug;
  }
 
  return true;