Go module, bump versions of k8s libs, rework of the Informer for namespaces (more suitable), rework of secretGenerator #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I moved the project to go module because we use it in my enterprise. Bumped some librairies.
Also I reworked the Informer because the one used was not really suitable for add cases like described in here. In doubt I Switched to a SharedInformer.
I reworked the SecretGenerator in a way that if there is no argument for one cloud provider, it won't create an empty secret and try to refresh it later.
I think there is more to do to refactor tests to reflect this change, because I needed to switch from 4 expected secrets to zero in several tests cases.
Also I change your Dockerfile for a multi build dockerfile with distroless base image but it was just for me because your image is lighter.
Anyway thanks for your work, I am now able to pull ECR images in newly created namespaces (with refresh setted at 1mn) with custom serviceAccountName.