This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
Use EIP 191 #82
Merged
Use EIP 191 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
reviewed
Nov 22, 2017
There was a problem hiding this comment.
Looks good to me, but this one is a good candidate for second review by @niran.
I did note that EIP 191 is not finalized, and the last two comments have a suggestion regarding cross-chain replay attack prevention.
Including the address of the txRelay in the hash inputs seems to minimize that risk.
niran
suggested changes
Nov 23, 2017
contracts/TxRelay.sol
Outdated
| // relay :: nonce :: destination :: data :: relayer | ||
| bytes32 h = sha3(this, nonce[claimedSender], destination, data); | ||
| // use EIP 191 | ||
| // 0x19 :: version :: relay :: nonce :: destination :: data :: relayer |
There was a problem hiding this comment.
Since we're changing this code, it's worth updating the comment to remove " :: relayer" at the end, which is no longer part of the plaintext.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71
NOTE: This should be merged after #81