Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

add meteor support for xmlhttprequest #3

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Conversation

zachferland
Copy link
Contributor

@zachferland zachferland commented Feb 15, 2017

Meteor builds include node-xmltthprequest rather than using window.xmlhttprequest. node-xmltthprequest has a bug in it, and doesn't seem to be pulling in PRs. Meteor builds use node-xmltthprequest since it ignores the browser field in the package.json, unless it is just a string - meteor/meteor#6890 (comment) . These changes allows meteor to use window.xmlhttprequest. (also reduces code, and does not affect local webpack builds)

@codecov-io
Copy link

Codecov Report

Merging #3 into develop will decrease coverage by -0.19%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop       #3      +/-   ##
===========================================
- Coverage    95.83%   95.65%   -0.19%     
===========================================
  Files            2        1       -1     
  Lines           48       46       -2     
  Branches        14       15       +1     
===========================================
- Hits            46       44       -2     
  Misses           2        2
Impacted Files Coverage Δ
src/index.js 95.65% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b77c3f...c0fc8d3. Read the comment docs.

Copy link
Contributor

@pelle pelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thankyou @zachferland

@pelle pelle merged commit e25ad30 into develop Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants