Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add did-peer provider and resolver #1156

Merged
merged 7 commits into from
Apr 6, 2023
Merged

Conversation

nickreynolds
Copy link
Contributor

@nickreynolds nickreynolds commented Apr 5, 2023

What issue is this PR fixing

closes #1105
fixes #1139

What is being changed

  • new package did-provider-peer added that contains a provider for did-peer as well as a resolver (that uses `@aviarytech/did-peer)
  • also includes fix for multibase public key conversion to hex

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

Adds an additional dependency (@aviarytech/did-peer)

@nickreynolds
Copy link
Contributor Author

@AlexAndrei98 provided the actual did-peer provider implementation

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 84.74% and project coverage change: +4.77 🎉

Comparison is base (125bf42) 80.25% compared to head (dfb84c1) 85.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1156      +/-   ##
==========================================
+ Coverage   80.25%   85.02%   +4.77%     
==========================================
  Files         118      154      +36     
  Lines        4056    15698   +11642     
  Branches      875     1655     +780     
==========================================
+ Hits         3255    13347   +10092     
- Misses        798     2351    +1553     
+ Partials        3        0       -3     
Impacted Files Coverage Δ
packages/core-types/src/coreEvents.ts 100.00% <ø> (ø)
...s/credential-ld/src/module-types/jsonld/index.d.ts 0.00% <0.00%> (ø)
packages/data-store-json/src/types.ts 0.00% <0.00%> (ø)
packages/did-comm/src/didcomm.ts 83.26% <ø> (+10.12%) ⬆️
packages/did-comm/src/index.ts 100.00% <ø> (ø)
packages/did-comm/src/message-handler.ts 72.10% <ø> (+12.64%) ⬆️
.../protocols/coordinate-mediation-message-handler.ts 89.63% <ø> (ø)
packages/did-comm/src/protocols/index.ts 100.00% <ø> (ø)
...omm/src/protocols/messagepickup-message-handler.ts 91.25% <ø> (ø)
.../did-comm/src/protocols/routing-message-handler.ts 89.65% <ø> (ø)
... and 83 more

... and 61 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlexAndrei98
Copy link

LGTM!

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@simonas-notcat simonas-notcat merged commit 9502063 into next Apr 6, 2023
@simonas-notcat simonas-notcat deleted the nickreynolds/did-peer branch April 6, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Ed25519VerificationKey publicKeyMultibase conversion [Adding did peer to the veramo framework]
3 participants