Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple NOTIFICATION_TELEGRAM_CHAT_ID #249

Merged
merged 5 commits into from
May 5, 2024

Conversation

gxres042
Copy link
Contributor

@gxres042 gxres042 commented May 4, 2024

With this PR, users can fill in multiple chat ids into NOTIFICATION_TELEGRAM_CHAT_ID like xxxxx, xxxxx.

Feature was requested there: https://github.com/orgs/upptime/discussions/956

Copy link
Member

@AnandChowdhary AnandChowdhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work!

src/helpers/notifme.ts Outdated Show resolved Hide resolved
src/helpers/notifme.ts Outdated Show resolved Hide resolved
@AnandChowdhary
Copy link
Member

I think there's something wrong here because there are two variables to deal with, NOTIFICATION_TELEGRAM_BOT_KEY and NOTIFICATION_TELEGRAM_CHAT_ID. Can you please check if we've used the right ones in the logic?

@gxres042
Copy link
Contributor Author

gxres042 commented May 4, 2024

I think there's something wrong here because there are two variables to deal with, NOTIFICATION_TELEGRAM_BOT_KEY and NOTIFICATION_TELEGRAM_CHAT_ID. Can you please check if we've used the right ones in the logic?

Any ways to use modified upptime-monitor with my upptime project?

Resolved, my mistake

@AnandChowdhary AnandChowdhary merged commit 1a286bd into upptime:master May 5, 2024
AnandChowdhary added a commit that referenced this pull request May 5, 2024
@upptime-bot
Copy link
Member

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants