-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nativeIO for madvise on mapped page cache #108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
===========================================
- Coverage 89.76% 89.17% -0.6%
- Complexity 723 724 +1
===========================================
Files 56 57 +1
Lines 2688 2725 +37
Branches 177 178 +1
===========================================
+ Hits 2413 2430 +17
- Misses 191 211 +20
Partials 84 84
Continue to review full report at Codecov.
|
Got the dylib included in the Jar - but I can't get the build to or load to support multiple targets (linux & mac) |
Closing based on revised implementation using JNR-FFI in #109 |
Changes:
Local benchmarking shows little impact on IO performance from use of madvise - this is good as impact might have been negative. Need to test under memory pressure at high IO in production environment. It would be ideal to develop a more rigorous local test with memory pressure.
The write to mapped change is an unexpected benefit. Need to test carefully in production as we have gone back and forth on this as a best practice. It looks like the latest iteration is a clear win for mapped IO as the benchmark time is cut in half!
See https://stackoverflow.com/a/49500154/2136991 for packaging & loading the dynamic library