go.mod: add a go.mod #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a go.mod to enable build and pin the dependencies versions.
|
I am not qualified to review a b2 PR, but note that go1.20 may be more portable in go.mod because of transition issues with the new toolchain downloads. On my system, these coredump, which I work around by setting toolchain=local. But if you're actually using new generics features or whatever, sure, go for go1.22.3. That's the Go version I have installed on my machine as well. |
|
I didn't change the code, so probably a 6 year old Go version would work. I will set Go 1.20 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a go.mod to enable build and pin the dependencies.
I used the Go version 1.22.3 because it's the version I'm using but maybe we should change it...
Another thing, I've noticed the https://github.com/kurin/blazer says its is no longer actively maintained and you can find the currently maintained repository at https://github.com/backblaze/blazer, but I kept the old one because it's working.